This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Ignore merge target when replacing template branch name. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows you to have builds using `master` as a template, but still have the build merge with master as part of the build config and not have that get replaced with a command to merge it with itself. It seems extremely unlikely that one would want to specify a merge command in the template build that would merge the template branch into itself, and expect that cloned builds would also be expected to merge into themselves. Much more likely is that the merge command is added specifically so cloned builds will attempt to merge into the template branch as part of the build process to ensure the code that would be built / tested is able to be merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to have builds using
masteras a template, but still havethe build merge with master as part of the build config and not have that
get replaced with a command to merge it with itself.
It seems extremely unlikely that one would want to specify a merge command
in the template build that would merge the template branch into itself,
and expect that cloned builds would also be expected to merge into themselves.
Much more likely is that the merge command is added specifically so cloned
builds will attempt to merge into the template branch as part of the build
process to ensure the code that would be built / tested is able to be merged.