Fix pattern matching on Java integer field #14458
Merged
+81
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akirathan
added
the
CI: No changelog needed
Akirathan
changed the title
Akirathan
requested review from
4e6,
AdRiley,
GregoryTravis,
JaroslavTulach,
hubertp and
jdunkerley
as code owners
hubertp
reviewed
Dec 9, 2025
Collaborator
hubertp
left a comment
hubertp
left a comment
There was a problem hiding this comment.
What about Byte, Short, Double?
jdunkerley
approved these changes
Dec 9, 2025
JaroslavTulach
requested changes
Dec 10, 2025
Member
There was a problem hiding this comment.
- I don't think
IsSameObjectNodeis the right place to handle non-longintegers - values allowed to flow in Enso interpreter are
long,double,boolean,TruffleObject
- I am not sure what exactly is
leftorrightin this case - but we certainly don't want any other values than the allowed ones
Member
Author
Yes. The failure was happening when there were two |
JaroslavTulach
approved these changes
Dec 10, 2025
| } | ||
|
|
||
| @Specialization | ||
| boolean isSameLong(long left, long right) { |
Member
There was a problem hiding this comment.
This looks like the right specialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14426
Pull Request Description
Fixes pattern matching on Java integer and long fields.
Important Notes
Fallback case branch in
DuckDB_Type_Mapping.ensono longer necessary - removed in 2a84ac4. See #14423 (comment)Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.