Skip to content

Conversation

@farmaazon
Copy link
Contributor

Pull Request Description

Fixes #14138

image

Important Notes

Ports are now stretched to the entire node's height. It doesn't look good, but I don't quite know how to make them "shrink" to content size, while still allowing content to be stretched if needed.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • [ ] Unit tests have been written where possible.
  • [ ] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@vitvakatu
Copy link
Contributor

Ports are now stretched to the entire node's height. It doesn't look good, but I don't quite know how to make them "shrink" to content size, while still allowing content to be stretched if needed.

I think height: min-content on WidgetPort does that, although I’m not sure if it looks good.

@farmaazon
Copy link
Contributor Author

Because drop down started looking bad in "expanded" nodes, I changed their style to more "generic pill" (same as in submenus):

image image

@AdRiley is it good enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On large vertical components we should align to the top

3 participants