Support opening project by clicking on link in documentation #14136
Conversation
somebody1234
requested review from
AdRiley,
kazcw and
vitvakatu
as code owners
somebody1234
changed the title
| @@ -1391,9 +1388,10 @@ export default class RemoteBackend extends Backend { | |||
|
|
|||
| /** Resolve asset metadata from an enso path. */ | |||
| override async resolveEnsoPath(path: backend.EnsoPath): Promise<backend.PathResolveResponse> { | |||
| const effectivePath = backend.EnsoPath(path.replace(/%20/g, ' ')) | |||
There was a problem hiding this comment.
There may be more characters escaped with % shouldn't we use decodeURI?
There was a problem hiding this comment.
i don't know, actually. i think this was an intentional choice, otherwise i would have used decodeURI, but tbf i can't be 100% sure... i suppose i should try testing
| ::after { | ||
| content: ''; | ||
| position: absolute; | ||
| inset: 0; | ||
| border-radius: var(--radius-full); | ||
| pointer-events: none; | ||
| } |
There was a problem hiding this comment.
This file seems to duplicate logic I'm currently working on in:
Also, the logic for opening project by path is implemented when reading URL path in route guard, so the project opening from link could be implemented by just navigating to proper path. It handles "opening vs navigation" too. The only thing you would need to check yourself is if to show OpenProjectDialog
|
waiting on @farmaazon 's changes (as mentioned above) before finishing refactor: |
|
new changes look ok ✅ |
farmaazon
left a comment
farmaazon
left a comment
There was a problem hiding this comment.
So I no longer block this PR :)
Pull Request Description
Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.