-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(crosschain resolver): simplify reverse resolver #379
Open
TateB
wants to merge
21
commits into
feature/crosschain-resolver-with-reverse-registrar
Choose a base branch
from
feature/simplify-reverse-resolver
base: feature/crosschain-resolver-with-reverse-registrar
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feature(crosschain resolver): simplify reverse resolver #379
TateB
wants to merge
21
commits into
feature/crosschain-resolver-with-reverse-registrar
from
feature/simplify-reverse-resolver
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult resolver Reverse Registrar
…ted default resolver Reverse Registrar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
SignatureReverseResolver
setText*
functionssetText
, since there is only one field setclearRecords
functionsauthorisedSignature
modifier andisAuthorisedWithSignature
func, switched to inlineisAuthorisedWithSignature
used in theauthorisedSignature
modifier requirednode
for the address which was calculated within the function itself.node
however was also used elsewhere in subsequent execution outside the modifier, and since modifiers can't return values it was unreachable. initially switched to just calling theisAuthorisedWithSignature
function inline, but it's only used once now (from the removal of setText/clearRecords), so it's just inline.bytes32
id replaced withbytes4, string
)name
variable ascalldata
instead ofmemory
L2ReverseResolver
ownerAndAuthorisedWithSignature
modifier function, logic now inlinename
variable ascalldata
instead ofmemory
ReverseRegistrar
relayer
argument insetNameForAddrWithSignature
andclaimForAddrWithSignature
msg.sender
anyway, and ifmsg.sender
isn't the relayer variable the signed message won't be verifiedname
variable ascalldata
instead ofmemory
sha3HexAddress
func fromLowLevelCallUtils
lib to standaloneAddressUtils