Skip to content

streamline prod vs dev builds #1694 #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skjulestad
Copy link

No description provided.

@skjulestad skjulestad requested a review from rymsha March 31, 2025 08:58
@skjulestad skjulestad self-assigned this Mar 31, 2025
@skjulestad skjulestad linked an issue Mar 31, 2025 that may be closed by this pull request
Copy link
Contributor

@rymsha rymsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to discuss how we proceed. There are conflicting ways to configure build
Some projects use -Penv=dev and use production build by default
Others use -Pdev or -Pdevelopment and also use production build by default
This PR changes form -Pdev to -Penv=dev, but uses development by default - that would require change is release-tools to make Github builds production ready

@sigdestad
Copy link
Member

Is there a way we could change this, so the -pDev mode is only used when running "enonic dev"? And then all other builds default to -pProd?

@rymsha
Copy link
Contributor

rymsha commented Mar 31, 2025

Is there a way we could change this, so the -pDev mode is only used when running "enonic dev"? And then all other builds default to -pProd?

This is up to CLI to specify -Pdev (or, rather -Penv=dev) when enonic dev is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

streamline prod vs dev builds
3 participants