Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (build): Add (initial) missing CI test coverage for DevEnv 🫙 #517

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vorburger
Copy link
Member

Relates to #458

@vorburger
Copy link
Member Author

vorburger commented Feb 20, 2024

As is, this currently fails on CI, due to:

#15 exporting layers 28.6s done
#15 writing image sha256:16f654ab58f4ad33c5973062c5e4a789b91dae2ffe0b55749bd5eec24d3b65aa done
#15 naming to docker.io/library/enola.dev-devenv done
#15 DONE 28.6s
the input device is not a TTY
Error: Process completed with exit code 1.

and I'm sure yet why... ideas welcome!

@vorburger
Copy link
Member Author

and I'm sure yet why... ideas welcome!

duh! That was just because the ./devenv.bash on CI cannot "enter the Terminal shell for a prompt" - only build it.

I've made it conditional now - that should hopefully do the trick...

@vorburger
Copy link
Member Author

Hm, but this will add 3m 41s to EVERY (no caching?!) build... I'm not entirely sure yet if I'm a huge fan of this.

@vorburger
Copy link
Member Author

Hm, but this will add 3m 41s to EVERY (no caching?!) build... I'm not entirely sure yet if I'm a huge fan of this.

No, wait a second, this adds >10' to every build! That's... really not great.

I would love to (have someone else?) further investigate 🔢 if there isn't a smart way to "cache Docker" (layers) on Actions, before merging this.

@vorburger vorburger marked this pull request as draft February 20, 2024 18:42
@vorburger
Copy link
Member Author

No, wait a second, this adds >10' to every build! That's... really not great. I would love to (have someone else?) further investigate 🔢 if there isn't a smart way to "cache Docker" (layers) on Actions, before merging this.

https://docs.docker.com/build/cache/backends/gha/ ? Seems simple enough...

But with hopefully we don't hit the 10 GB limit...

@vorburger vorburger marked this pull request as ready for review February 21, 2024 22:10
@vorburger vorburger added the build Build, CI, etc. (w.o. #testing) label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build, CI, etc. (w.o. #testing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant