-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draw directional arrows on lines and circles #73
base: master
Are you sure you want to change the base?
Conversation
This is quite slow, so probably needs some thought
…/ganja.js into eric-wieser-add-direction-arrows
This is potentially a tiny bit more performant, as now marker defs are only created for each distinct color. |
I think the performance hit comes from switching from |
awesome, hoping this makes it through to the conformal 3D visualiser, would in general make it a lot easier to keep track of the orientation of GA blades |
This also fixes a bug where in a changing document, the marker colors become stuck at the first color emitted. |
75fbf22
to
00eae87
Compare
Thank you for this great work! I am just playing around with it, figured that Can this be integrated or is there some blocking issue? When performance is the only problem, why not make it an option? Slow/fast, for debugging. |
Unfortunately this probably needs to be rebuilt from scratch - the long and dense lines of ganja.js make git useless at trying to merge in the changes. At any rate, I think @enkimute said they had their own variant of this in the works. |
This is quite slow, so probably needs some more thought
It also seems to trigger a rendering bug (pixellation) in chrome: