Skip to content

Conversation

@kanywst
Copy link

@kanywst kanywst commented Jun 23, 2025

Overview

Enhanced the shutdown functionality to accept a context parameter, allowing for more control over timeout settings and other context-specific configurations during the shutdown process.

Changes

  • Added a new ShutdownWithContext(ctx context.Context) function that accepts a user-provided context
  • Refactored the existing Shutdown() function to use ShutdownWithContext() with context.Background() for backward compatibility
  • The new function uses the provided context to shut down the server gracefully

Testing

  • Added unit tests to verify the new functionality works as expected

Related Issue

#172

refactor: improve shutdown function documentation and test descriptions

fix: improve comment clarity for Shutdown function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant