feat: enable various outputs (yaml, json) for clusterstatus #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(pending py38 drop #53 , so i can remove the try/except) |
ylmrx
force-pushed
the
feat/enable_outputs_clusterstatus
branch
2 times, most recently
from
adf5fa9 to
3c41e1f
Compare
ylmrx
force-pushed
the
feat/enable_outputs_clusterstatus
branch
from
3c41e1f to
4499bd6
Compare
plaffitt
reviewed
Mar 19, 2025
Comment on lines
+39
to
+51
| output = f"""\ | ||
| Status: {status} | ||
| VMs: {vms - templates} | ||
| Templates: {templates} | ||
| Metrics: | ||
| CPU: {_get_cpu_output()} | ||
| Memory: {_get_memory_output()} | ||
| Disk: {_get_disk_output()} | ||
| Nodes: | ||
| Offline: {len([node for node in proxmox.nodes if node.status == NodeStatus.OFFLINE])} | ||
| Online: {len([node for node in proxmox.nodes if node.status == NodeStatus.ONLINE])} | ||
| Unknown: {len([node for node in proxmox.nodes if node.status == NodeStatus.UNKNOWN])} | ||
| """ |
There was a problem hiding this comment.
In a sense we can argue that this provides a "better output", but in the other hand I was quite fine with the previous output. I feel like it was intentional to prepend every lines with a double space and start the output with a \n to clearly delimitate the output from previous logs (INFO:root:Proxmox cluster: XXX for instance).
Any thoughts about it @lcaflc?
ylmrx
force-pushed
the
feat/enable_outputs_clusterstatus
branch
from
4499bd6 to
55b9757
Compare
ylmrx
force-pushed
the
feat/enable_outputs_clusterstatus
branch
from
55b9757 to
9092ef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-o format) option forclusterstatus-o md) (kudos @abuisine suggestion)