Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new and pre-release Java builds #600

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bowbahdoe
Copy link

  • Adds a newer stable version of Java than 15 w/ 20
  • Adds some early access builds as well

The reason I want 21-ea specifically is so that I can have my book run code snippets using anonymains
https://openjdk.org/jeps/445

@bowbahdoe
Copy link
Author

Also, huge apologies if they don't build. I see the other github issue where the person didn't build them locally and that was bad, but I have an M1 mac so the docker images actually don't work on my machine. I would likely have to use the workflow here to validate unfortunately :(

@bowbahdoe
Copy link
Author

bowbahdoe commented May 18, 2023

Good news! got a linux laptop to test all of this and they did build with some changes

Bad news! The entire reason i want to have these ea builds is moot since the change hasnt been merged in yet. Kindof a bummer, but it will come out eventually and the central question of "would the piston folks be okay adding pre-release java builds to the public api/built in set" is still worth figuring out/for me

@@ -0,0 +1,5 @@
{
"language": "java",
"version": "20.valhalla.20.75",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how semver compliant this version number is

@bowbahdoe
Copy link
Author

I ended up giving up waiting for this and forked the rust playground to do what I wanted. https://java-playground.com

I'll leave the issue up in case anyone else is still interested, but i've moved on.

@HexF HexF marked this pull request as draft November 1, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants