feat(common): Improve objectMap typing #2730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
It all looks reasonable, but tsc is often unreasonable so without tests I'm not 100% sure it does work.
Edit: oh I see Agoric/agoric-sdk#11064
| * const Entries extends ReadonlyArray<readonly [PropertyKey, unknown]>, | ||
| * >( | ||
| * entries: Entries, | ||
| * ) => { [Entry in Entries[number] as Entry[0]]: Entry[1] }} FromTypedEntries |
| const mapEntry = ([k, v]) => [k, mapFn(v, k)]; | ||
| const newEntries = typedMap(oldEntries, mapEntry); | ||
| const newObj = fromTypedEntries(newEntries); | ||
| return /** @type {any} */ (harden(newObj)); |
There was a problem hiding this comment.
I'm not sure; it seems to have just gotten super confused:
Type '{ [Entry in [keyof O, R] as Entry[0]]: Entry[1]; }' is not assignable to type '{ [K in keyof O]: K extends string ? R : never; }'.
Type 'keyof O' is not assignable to type '[keyof O, R]'.
Type 'string | number | symbol' is not assignable to type '[keyof O, R]'.
Type 'string' is not assignable to type '[keyof O, R]'.(2322)
There was a problem hiding this comment.
Looks like the type mapping failing ...
There was a problem hiding this comment.
Possibly microsoft/TypeScript#49653 (comment) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inspired by Agoric/agoric-sdk#11040 , try to type
objectMapmore precisely. I'm interested to see what this breaks.agoric-sdk integration PR: Agoric/agoric-sdk#11064