chore: Drop Node.js 16 from CI entirely #2140
Conversation
| # '20.6' not viable due to https://github.com/nodejs/node/issues/49497 | ||
| # '20.3' to '20.6' not viable due to https://github.com/nodejs/node/pull/49211 |
There was a problem hiding this comment.
question
Worth a revisit to these versions? Look like both issues are closed
There was a problem hiding this comment.
We only need one Node 20. It turned out to be 20.9 (not 20.7 that the line below enables)
| @@ -13,7 +13,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| node-version: ['16.x'] | |||
There was a problem hiding this comment.
question
Why not add node 20 here?
There was a problem hiding this comment.
Because this is isn't testing the code, just the project structure.
I propose that it drop the matrix because it won't ever use it.
There was a problem hiding this comment.
I would like to attack Node.js 20 in another change.
There was a problem hiding this comment.
I can't tell, what is your opinion on running the cycles and depcheck in multiple versions of Node?
There was a problem hiding this comment.
I agree that we only need to run these checks in one version of Node.js and we could drop the matrix.
|
See also Agoric/agoric-sdk#8365 |
kriskowal
force-pushed
the
kriskowal-drop-node-16-1046
branch
from
ffb29e0 to
f3269df
Compare
kriskowal
force-pushed
the
kriskowal-drop-node-16-1046
branch
from
f3269df to
0380357
Compare
closes: #1046
Description
This removes the last two vestiges of testing on Node.js 16. Depcheck was on 16 by omission. The remaining CI matrix tests were for preventing regressions in
async_hookshandling, which are leaving firmly behind us. We may at this point remove the promise-kit accommodations for these earlier versions, but that is not in scope for this change.Security Considerations
none
Scaling Considerations
none
Documentation Considerations
We may need to document somewhere that we no longer test Node.js. We have elected not to use the
enginesfield inpackage.jsonsince that would be brittle.Testing Considerations
fewer
Compatibility Considerations
none
Upgrade Considerations
none to my knowledge