Sourcery refactored master branch

[sourcery-ai]

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

[sourcery-ai]

Lines 506-508 refactored with the following changes:

• Convert for loop into dictionary comprehension (dict-comprehension)

[sourcery-ai]

Function registrationsFromFile refactored with the following changes:

• Replace assignment with augmented assignment (aug-assign)

[sourcery-ai]

Function nextOrder refactored with the following changes:

• Merge nested if conditions (merge-nested-ifs)
• Use any() instead of for loop (use-any)

[sourcery-ai]

Function nextGeneration refactored with the following changes:

• Merge nested if conditions (merge-nested-ifs)
• Use any() instead of for loop (use-any)

[sourcery-ai]

Lines 506-508 refactored with the following changes:

• Convert for loop into dictionary comprehension (dict-comprehension)

[sourcery-ai]

Function _encode_i2c refactored with the following changes:

• Replace unused for index with underscore (for-index-underscore)

[sourcery-ai]

Function _decode_c2i refactored with the following changes:

• Replace assignment with augmented assignment (aug-assign)

[sourcery-ai]

Function PpidCounts2KML.run refactored with the following changes:

• Replace assignment with augmented assignment (aug-assign)

[sourcery-ai]

Sourcery Code Quality Report (beta)

✅ Merging this PR will increase code quality in the affected files by 0.06 out of 10.

	Before	After	Change
Quality	7.45	7.51	0.06
Complexity	6.6	6.09	-0.51
Method Length	161.45	160.77	-0.69
Lines	1714	1704	-10

Changed files	Quality Before	Quality After	Quality Change
bin/CsvJoiner.py	7.24	7.29	0.05 ⬆️
bin/avgRegistrationResponseTimes	9.12	9.14	0.03 ⬆️
bin/drawDeps.py	5.98	6.38	0.4 ⬆️
geo/CountryCodeToName.py	7.24	7.29	0.05 ⬆️
geo/geohash.py	6.78	6.79	0.01 ⬆️
geo/ppidCounts2kml.py	8.98	8.99	0.01 ⬆️

Here are some functions in these files that still need a tune-up:

File	Function	Quality	Recommendation
geo/geohash.py	expand_uint64	0.57	Reduce complexity. Split out functionality
geo/geohash.py	encode	3.8	Split out functionality
geo/geohash.py	bbox	5.48	Split out functionality
geo/geohash.py	decode	5.6	Split out functionality
geo/geohash.py	_float_hex_to_int	6.5	Split out functionality

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it via email or our Gitter!