PutGateFromFile: tokens are of type int in general #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is dependent on ENCRYPTO_utils's tokenize_verilog making the same change.
dd23
force-pushed
the
public
branch
4 times, most recently
from
2b13460
to
e7a5ddb
Compare
|
Please comment @lenerd |
|
We kind of misused -2 and -3 to signal constant 0 and 1 in the circuits files here: https://github.com/encryptogroup/ABY/tree/public/bin/circ Currently the negative numbers end up interpreted as unsigned ones, so e.g. as 4294967294. This is ugly, but worked so far, as long as no one loads files with 4294967294 or more wires... If this change does not break the circuits (https://github.com/encryptogroup/ABY/tree/public/src/examples/float), we can merge it. Or we should check what else needs to be fixed, so we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general,
.abytokens can have a sign.encryptogroup/ENCRYPTO_utils#13 has to be merged first.