Thread pool is no longer used for files in memory #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thread pool is no longer used for files in memory
tomchristie
reviewed
May 6, 2020
tomchristie
reviewed
May 6, 2020
tests/test_datastructures.py
Outdated
| @@ -210,6 +213,17 @@ def test_queryparams(): | |||
| assert QueryParams(q) == q | |||
|
|
|||
|
|
|||
| @pytest.mark.asyncio | |||
| async def test_upload_file(): | |||
| UploadFile.spool_max_size = 1024 | |||
There was a problem hiding this comment.
We're changing this class attribute across all the test cases. Probably doesn't really matter, but we could alternately do something like...
TestUploadFile(UploadFile):
spool_max_size = 1024And use that?
Also perhaps we should assert that the .read is returning the expected data?
There was a problem hiding this comment.
I agree. I will modify the test code here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #819
Here I made a judgment, when the file is in memory, no longer use the thread pool to operate. This can save a lot of thread switching time.