Add missing AnyIO import - #1107
Open
EmmanuelNiyonshuti wants to merge 1 commit into
Open
Conversation
Author
|
I am not sure the ci failure is related to this PR. |
Contributor
|
This PR is not likely to be ever merged, as httpcore is no longer used by any maintained downstream project. |
Member
|
This particular issues looks like it’ll merit a new httpx release. Presumably that changed has broken a large number of async installs. |
Contributor
|
I do have a workaround PR almost ready. |
Author
|
AnyIO 4.15.1 includes a workaround for this. It's resolved regardless of whether this PR get merged. I'll go ahead and close this. |
Contributor
|
It's a trivial change and improves correctness so I'd vote for it being merged anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpcore/_backends/anyio improperly uses the anyio.abc module without importing it. With AnyIO 4.15.0's lazy re-exports, much fewer modules are imported as a side-effect which then exposed this problem.
This PR add missing AnyIO import used in httpcore/_backends/anyio.
Ref: agronholm/anyio#1308
Checklist