Fix test_regular_fields for Django 5.x BigIntegerField constraints #9771
+27
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
reviewed
Sep 4, 2025
browniebroke
reviewed
Sep 5, 2025
Comment on lines
+172
to
+179
| boolean_field = BooleanField\(.*\) | ||
| char_field = CharField\(.*\) | ||
| comma_separated_integer_field = CharField\(.*\) | ||
| date_field = DateField\(.*\) | ||
| datetime_field = DateTimeField\(.*\) | ||
| decimal_field = DecimalField\(.*\) | ||
| email_field = EmailField\(.*\) | ||
| float_field = FloatField\(.*\) |
There was a problem hiding this comment.
It feels like this is is changing more than needed... What was the rationale for changing these seemingly unrelated fields to have a .* in the kwargs?
|
Has this issue been fixed? Because I tried recreating it, but none of the test cases fail. I'm on Django 5.2.5 |
Yes, good question. Looking again at the changes, I'm not sure I understand what is the problem here. I see no failures on my end either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Before submitting a code change, please review our contributing guidelines.
Description
Django 5.x now attaches min_value and max_value automatically to BigIntegerField.
This PR updates the test regex in TestRegularFieldMappings.test_regular_fields to accept these constraints.
Without this change, tests fail under Django 5.2.5.