Skip to content

WRR-21724: Fixed help icon in Hebrew locale to not flip#1814

Merged
mmyelyn merged 3 commits intorelease/2.9.x.developfrom
feature/WRR-21724-2.9
Mar 25, 2025
Merged

WRR-21724: Fixed help icon in Hebrew locale to not flip#1814
mmyelyn merged 3 commits intorelease/2.9.x.developfrom
feature/WRR-21724-2.9

Conversation

@juwonjeong
Copy link
Copy Markdown
Contributor

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

In hebrew locale, 'help' icon should not flip horizontal when flip prop is auto.

Resolution

Check if the locale and children is he-IL and help when deciding whether to flip.

Additional Considerations

Links

WRR-21724

Comments

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (a6a80dd) to head (9a1c32d).
Report is 1 commits behind head on release/2.9.x.develop.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           release/2.9.x.develop    #1814   +/-   ##
======================================================
  Coverage                  80.90%   80.91%           
======================================================
  Files                        148      148           
  Lines                       6718     6721    +3     
  Branches                    2005     2006    +1     
======================================================
+ Hits                        5435     5438    +3     
  Misses                       973      973           
  Partials                     310      310           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
@mmyelyn
Copy link
Copy Markdown
Contributor

mmyelyn commented Mar 25, 2025

Please resolve the CHANGELOG conflicts

@mmyelyn mmyelyn merged commit 4505786 into release/2.9.x.develop Mar 25, 2025
5 checks passed
@mmyelyn mmyelyn deleted the feature/WRR-21724-2.9 branch March 25, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants