[wangyenshu]

Template B: Checklist for updating a package

• ⚠️ Bump build number if the version remains unchanged
• Or reset build number to 0 if updating the package to a newer version

---

PR Formatting

• PR title follows format: Add [package-name] or Update [package-name] to [version]
• PR description includes:
  • Version being added/updated
  • Any special build considerations or patches applied

Package Details

• Package Name: gap
• Version: 4.16.1

Build Notes

[wangyenshu]

I can confirm that gap works after this fix.

[wangyenshu]

passagemath-gap test says

=================================== FAILURES ===================================
_________________________ test_import_passagemath_gap __________________________
    def test_import_passagemath_gap():
>       import passagemath_gap
E       ModuleNotFoundError: No module named 'passagemath_gap'
test_passagemath_gap.py:5: ModuleNotFoundError
_________________________________ test_libgap __________________________________
    def test_libgap():
>       import passagemath_gap
E       ModuleNotFoundError: No module named 'passagemath_gap'
test_passagemath_gap.py:9: ModuleNotFoundError
=========================== short test summary info ============================

I guess that this is not the gap's issue.

[IsabelParedes]

I guess that this is not the gap's issue.

Something seems to be broken with python tests. Investigating...

[IsabelParedes]

The issue with the python tests is fixed now, if you'd like to test passagemath-gap again :)

[IsabelParedes]

error while evaluating main file: Error: Dynamic linking error: cannot resolve symbol invoke_viii

This generally indicates that -fexceptions was used somewhere, but everything should use -fwasm-exceptions instead.

[wangyenshu]

error while evaluating main file: Error: Dynamic linking error: cannot resolve symbol invoke_viii

This generally indicates that -fexceptions was used somewhere, but everything should use -fwasm-exceptions instead.

But fwasm is not compatible with asyncify, which is required by gap's garbage collecting mechanism.

[IsabelParedes]

Since the changes to gap break passagemath-gap, I would like to get @mkoeppe opinion before merging.

Thank you!

[wangyenshu]

Is it possible for the passagemath-gap test to work without -fwasm?

[mkoeppe]

Since the changes to gap break passagemath-gap, I would like to get @mkoeppe opinion before merging.

Unfortunately I don't understand the constraints of this platform well enough to comment... What's going on in the dynamic linking of the Python modules that is failing here, and why is dynamic linking otherwise generally avoided in the emscripten-forge recipes?

[wangyenshu]

Since the changes to gap break passagemath-gap, I would like to get @mkoeppe opinion before merging.

Unfortunately I don't understand the constraints of this platform well enough to comment... What's going on in the dynamic linking of the Python modules that is failing here, and why is dynamic linking otherwise generally avoided in the emscripten-forge recipes?

invoke_viii should be relevant to the JavaScript-based exception handling (-fexceptions). Most of the recipe here is built with WebAssembly-based exception handling (-fwasm). That should be the reason for failing. However, gap relies on asyncify flag which is not compatible with -fwasm.

[IsabelParedes]

Thank you!

If this causes issues for passagemath-gap, we can pin it to a previous build or split the gap package as needed.

[wangyenshu]

Claude suggested splitting gap recipe to build libgap.a without ASYNCIFY. passagemath-gap only need libgap.a right? @mkoeppe

[mkoeppe]

No, it needs all of GAP, except for the executable program.

[wangyenshu]

That is a problem. The pkg dir of gap is 1GB size large. Even after gzip it is still 500MB. GitHub will not allow hosting such large file in pages.

[mkoeppe]

To clarify, of course it does not need all GAP packages up front.
In passagemath, I modularize GAP by shipping many of the large data packages and some excessively large code packages separately.

• https://github.com/passagemath/passagemath/blob/main/pkgs/sagemath-gap/pyproject.toml.m4#L30
• https://github.com/passagemath/passagemath/blob/main/pkgs/sagemath-gap/repair_wheel.py#L26