Skip to content

Check downloaded file size in urllib path #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbc100 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check downloaded file size in urllib path #1784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions emsdk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,12 @@ def download_with_urllib(url, file_name):
print(']')
sys.stdout.flush()

if file_size_dl == 0:
raise RuntimeError('download failed: received 0 bytes')

if file_size > 0 and file_size_dl != file_size:
raise RuntimeError(f'download size mismatch: received {file_size_dl} bytes, expected {file_size} bytes')

debug_print('finished downloading (%d bytes)' % file_size_dl)


Expand Down Expand Up @@ -722,6 +728,7 @@ def download_file(url, dstpath, filename_prefix=''):
download_with_urllib(url, file_name)
except Exception as e:
errlog(f"Error: Downloading URL '{url}': {e}")
rmfile(file_name)
return None
except KeyboardInterrupt:
rmfile(file_name)
Expand Down