Remove support for non-standard -no-pthreads command line flag - #27546
Conversation
It turns out this was never really supported by LLVM in the way I thought it was when I added support here: llvm/llvm-project#216378
|
Since we've removed the support from LLVM then definitely LGTM for removing the test for right now. Given that we have this test though I wonder if this flag actually had users. If it really did have the effect we want, it doesn't seem too onerous to keep support in LLVM if it was actually useful? |
|
Yes @RReverser certainly had a use for in #20720. Hopefully he found another way to solve that issue? We could continue to try to honor in emcc-only (i.e. not in clang itself), but I would rather not diverge if possible. |
|
Well if we're going to support it, it would certainly make sense to do it in clang upstream rather than in emcc. Your patch to remove it from upstream was pretty trivial, so I'm saying if it was already WAI and has a benefit, then we could consider just reverting that. It would be a divergence from other targets but there are plenty of those already. |
The problem is that the the upstream support was basically not WAI, at least for for compiling. The shared code that calls clang cc1 is here and it ignores Also, no other frontends were taking any action based on this flag, so wasm the only outlier. |
|
OK yeah if it was always broken then it makes sense just to remove it |
|
Going to go ahead and merge this now to fix the roller |
2 participants
It turns out this was never really supported by LLVM in the way I thought it was when I added support here:
llvm/llvm-project#216378
I'm pretty we never advertised the availability of this non-standard flag anywhere so I think removing it should be low risk. See #20723 for where it was added.