Add deprecation attributes to deprecated struct fields - #27545
Open
sbc100 wants to merge 1 commit into
Open
Conversation
sbc100
force-pushed
the
html5-deprecated-fields
branch
from
August 15, 2026 00:09
c3c512c to
8792ec1
Compare
sbc100
changed the title
sbc100
changed the title
Mark deprecated fields in `EmscriptenKeyboardEvent`, `EmscriptenMouseEvent`, and `EmscriptenTouchPoint` with `__attribute__((deprecated(...)))` attributes in `html5.h`, and add corresponding warnings in `html5.h.rst`. Also add deprecation message to `emscripten_fetch_wait` in `fetch.h`, and add `-Wno-deprecated-declarations` to existing tests that inspect deprecated fields.
sbc100
force-pushed
the
html5-deprecated-fields
branch
from
August 15, 2026 00:14
8792ec1 to
d26c3ab
Compare
kripken
reviewed
Aug 17, 2026
| the nearest integer). | ||
|
|
||
| .. warning:: These attributes are deprecated. Register a listener on the | ||
| canvas directly to get canvas coordinates, or translate manually. |
Member
There was a problem hiding this comment.
Perhaps link to where this was deprecated? (where was that?)
Member
There was a problem hiding this comment.
Similar questions for the others - I'm not sure how to verify that we deprecated these.
Collaborator
Author
There was a problem hiding this comment.
There was a comment in the header file, but it was not previously reflected in the docs:
emscripten/system/include/emscripten/html5.h
Line 129 in c333eb4
Collaborator
Author
There was a problem hiding this comment.
Oh, you mean the commit which deprecated them, maybe? That was #7977. I'll add that the PR desc too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark deprecated fields in
EmscriptenKeyboardEvent,EmscriptenMouseEvent, andEmscriptenTouchPointwith__attribute__((deprecated(...)))attributes inhtml5.h, and addcorresponding warnings in
html5.h.rst.Also add deprecation message to
emscripten_fetch_waitinfetch.h,and add
-Wno-deprecated-declarationsto existing tests that inspectdeprecated fields.
canvasXandcanvasYwere documented as deprecated in #7977.