Replace handcoded native signature mapping with auto-generated one#27150
Open
sbc100 wants to merge 1 commit into
Open
Replace handcoded native signature mapping with auto-generated one#27150sbc100 wants to merge 1 commit into
sbc100 wants to merge 1 commit into
Conversation
sbc100
changed the title
kripken
reviewed
Jun 18, 2026
sbc100
force-pushed
the
native-sigs
branch
3 times, most recently
from
a6c94b2 to
d6e54b0
Compare
kripken
approved these changes
Jun 18, 2026
sbc100
force-pushed
the
native-sigs
branch
2 times, most recently
from
529b426 to
22dd774
Compare
kleisauke
approved these changes
Jun 19, 2026
sbc100
changed the title
Replace the hardcoded mapping in `create_pointer_conversion_wrappers` with a Python module loaded at runtime. Add `tools/maint/gen_native_sig_info.py` to regenerate this module by comparing wasm32 and wasm64 builds to detect pointer arguments. Signature changes/corrections: - `_emscripten_proxy_poll_finish`: Removed (dead code). - `setThrew`: Corrected from `_p` to `_p_` (has 2 arguments in C). - `_wasmfs_get_cwd`: Corrected from `p_` to `p` (has 0 arguments in C). - Void returns: Inconsistent `vp` signatures (e.g. `emscripten_builtin_free`, `stbi_image_free`) normalized to `_p`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hardcoded mapping in
create_pointer_conversion_wrapperswith a Python module loaded at runtime.Add
tools/maint/gen_native_sig_info.pyto regenerate this module by comparing wasm32 and wasm64 builds to detect pointer arguments.Signature changes/corrections:
_emscripten_proxy_poll_finish: Removed (dead code).setThrew: Corrected from_pto_p_(has 2 arguments in C)._wasmfs_get_cwd: Corrected fromp_top(has 0 arguments in C).vpsignatures (e.g.emscripten_builtin_free,stbi_image_free) normalized to_p.