[ASYNCIFY] Convert remaining async JS function to use auto
#26117
+10
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
async_auto_part2
branch
from
c32f5f3 to
f3ca2fb
Compare
sbc100
force-pushed
the
async_auto_part2
branch
2 times, most recently
from
03f1311 to
88542e2
Compare
kripken
approved these changes
Jan 16, 2026
The only function that remains that still uses `async: true` is `emscripten_fiber_swap`, and this is because it doesn't use handleSleep or handleAsync, so is not a candidate for `async: auto`. Followup to emscripten-core#26019 and emscripten-core#26095.
sbc100
force-pushed
the
async_auto_part2
branch
from
88542e2 to
2fc70a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only function that remains that still uses
async: trueisemscripten_fiber_swap, and this is because it doesn't use handleSleep or handleAsync, so is not a candidate forasync: auto.Followup to #26019 and #26095.