Use async: auto for dlopen_js. NFC
#26111
Merged
+34
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
async: auto for dlopen_js. NFC
sbc100
commented
Jan 14, 2026
sbc100
force-pushed
the
dlopen_js__async
branch
from
3f69387 to
576621b
Compare
sbc100
force-pushed
the
dlopen_js__async
branch
2 times, most recently
from
b96d4c1 to
ffce025
Compare
kripken
reviewed
Jan 15, 2026
kripken
reviewed
Jan 15, 2026
sbc100
force-pushed
the
dlopen_js__async
branch
from
ffce025 to
06cbd95
Compare
sbc100
force-pushed
the
dlopen_js__async
branch
from
06cbd95 to
4f28da5
Compare
brendandahl
approved these changes
Jan 15, 2026
Followup to emscripten-core#26019. I'm not sure about the meaning of the comment here, but `__async: auto` uses `handleAsync` under the hood and it seems to work just fine.
sbc100
force-pushed
the
dlopen_js__async
branch
from
4f28da5 to
9e8ab02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #26019 and #26095.
The old comment here is, I believe, no longer valid now that #26095 has landed.