Remove redundant null chaining. NFC #25643
Merged
+26
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Speaking of which, I assume there is a reason we use |
sbc100
force-pushed
the
minimum_runtime_check2
branch
from
77892a2 to
c2fd910
Compare
This was one of the review comments: #25414 (comment) . The idea here was that even if this code is run on a very old browser, it would still work. Though now I realize that I was using So if something, it would probably be good to remove uses of ES6 altogether in this code. |
juj
approved these changes
Oct 24, 2025
This null chaining operator is not only redundant (because it happens only after a typeof check), but simply doesn't work. One cannot do `foo?.bar` if `foo` does not exist. One would need to instead do `globalThis?.foo?.bar`.
sbc100
force-pushed
the
minimum_runtime_check2
branch
from
c2fd910 to
70ed25c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This null chaining operator is not only redundant (because it happens only after a typeof check), but simply doesn't work.
One cannot do
foo?.bariffoodoes not exist. One would need to instead doglobalThis?.foo?.bar.