Remove references to mozRequestPointerLock and friends. NFC
#24603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
mozRequestPointerLock
branch
2 times, most recently
from
930165c to
a26aed9
Compare
sbc100
force-pushed
the
mozRequestPointerLock
branch
from
a26aed9 to
1600f8c
Compare
kripken
approved these changes
Jun 18, 2025
sbc100
force-pushed
the
mozRequestPointerLock
branch
from
1600f8c to
c1a1a65
Compare
RReverser
reviewed
Jun 18, 2025
The official `requestPointerLock` API is supported in all the browsers that we support. See https://developer.mozilla.org/en-US/docs/Web/API/Element/requestPointerLock
sbc100
force-pushed
the
mozRequestPointerLock
branch
from
c1a1a65 to
d5cb41d
Compare
RReverser
approved these changes
Jun 18, 2025
|
In case you decide to go on a rampage, this regex should help find other potentially outdated fallbacks: https://github.com/search?q=repo%3Aemscripten-core%2Femscripten+%2F%28%3F-i%29%28%5Cb%28moz%7Cwebkit%7Cms%29%5BA-Z%5D%7C%5C-%28moz%7Cwebkit%7Cms%7Co%29-%29%2F+&type=code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official
requestPointerLockAPI is supported in all the browsers that we support.See https://developer.mozilla.org/en-US/docs/Web/API/Element/requestPointerLock