-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update update_libcxx.py to handle recent changes #24392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- `update_libcxx.py` update - Now it handles the new `llvm-libc` directory - It exclude unused `ryu_(long_double)constants.h` from libc - It deletes `libcxx/include/__cxx03` for now because we are not using it. - Make `clean_dir` and `copy_tree` handle the case when the local dir does not exist, which can happen when new directories are added - Make `copy_tree` handle removing files in `excludes` when they are in subdirectories (In libc, many `CMakeLists.txt` are in subdirectories) This also adds `readme.txt` to `llvm-libc` directory.
system/lib/update_libcxx.py
Outdated
('include', 'llvm-libc-types'), | ||
('shared',), | ||
('src', '__support'), | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these go at the top level with the the file lists like preserve_files and excludes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (Changed the variable name to libc_copy_dirs
)
Running 'git status --short'
M system/lib/llvm-libc/README.txt
Checkout is not clean. See above for list of dirty/untracked files.
Exited with code exit status 1 Not sure what happened, but is there a way to clean the working directory? |
Somehow the README file is being updated during the build... that seems odd? Each test run starts off clean |
You try |
Oh interesting you are trying to add a |
Ah thanks! |
update_libcxx.py
updatesllvm-libc
directoryryu_(long_double)constants.h
from libclibcxx/include/__cxx03
for now because we are not using it.clean_dir
andcopy_tree
handle the case when the local dir does not exist, which can happen when new directories are addedcopy_tree
handle removing files inexcludes
when they are in subdirectories (In libc, manyCMakeLists.txt
are in subdirectories)This also adds
readme.txt
tollvm-libc
directory.