Merge test_fs_open_no_permissions with test_fcntl_open. NFC #23231
Conversation
hoodmane
force-pushed
the
merge-open-no-permissions-test
branch
from
087129c to
27b88f4
Compare
Co-authored-by: Derek Schuff <[email protected]>
| assert(res >= 0); | ||
| struct stat st; | ||
| assert(stat("a", &st) == 0); | ||
| assert((st.st_mode & 0777) == 0); |
There was a problem hiding this comment.
Is this the line that fails on windows? Perhaps we could make it more flexible?
As it stands if we add @no_windows the whole test will no longer run on windows. Alternatively you could do this:
if self.getsetting('NODERAWFS') and WINDOWS:
self.skipTest(...)
That way only that particular variant will be skipped.
There was a problem hiding this comment.
Yeah, that's the one: See https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8728106183896305361/+/u/Emscripten_testsuite__core0_/stdout (line 19 of the original)
There was a problem hiding this comment.
But it also fails on nodefs, not just on noderawfs.
There was a problem hiding this comment.
We have a bunch of test that have something like if nodefs and WINDOWS: skip.. so we can do that here to maybe?
No description provided.