Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify setting _scriptName and scriptDirectory. NFC #23214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unify setting _scriptName and scriptDirectory. NFC #23214

wants to merge 1 commit into from

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Dec 18, 2024 •
edited
Loading

This moves the code for setting these into a single place and avoids duplication making scriptDirectory depend on _scriptName.

@sbc100 sbc100 changed the title Unify settings of _scriptName and scriptDirectory. NFC Unify setting _scriptName and scriptDirectory. NFC Dec 18, 2024
@sbc100 sbc100 force-pushed the unify_scriptDirectory branch 2 times, most recently from 4a1f8c8 to 0a10714 Compare December 18, 2024 18:24
@sbc100 sbc100 requested a review from kripken December 18, 2024 18:34
@sbc100 sbc100 force-pushed the unify_scriptDirectory branch 3 times, most recently from a5ae024 to 505f533 Compare December 18, 2024 20:04
@sbc100
Unify settings of _scriptName and scriptDirectory. NFC
3d41373 
This move the code for setting these into a single place and avoids
duplication.

Automatic rebaseline of codesize expectations. NFC

This is an automatic change generated by tools/maint/rebaseline_tests.py.

The following (71) test expectation files were updated by
running the tests with `--rebaseline`:

```
browser/test_small_js_flags.js.size: 4380 => 4371 [-9 bytes / -0.21%]
other/codesize/test_codesize_cxx_ctors1.gzsize: 8352 => 8361 [+9 bytes / +0.11%]
other/codesize/test_codesize_cxx_ctors2.gzsize: 8336 => 8346 [+10 bytes / +0.12%]
other/codesize/test_codesize_cxx_except.gzsize: 9358 => 9369 [+11 bytes / +0.12%]
other/codesize/test_codesize_cxx_except_wasm.gzsize: 8321 => 8325 [+4 bytes / +0.05%]
other/codesize/test_codesize_cxx_except_wasm_exnref.gzsize: 8321 => 8325 [+4 bytes / +0.05%]
other/codesize/test_codesize_cxx_lto.gzsize: 8348 => 8356 [+8 bytes / +0.10%]
other/codesize/test_codesize_cxx_mangle.gzsize: 9361 => 9370 [+9 bytes / +0.10%]
other/codesize/test_codesize_cxx_noexcept.gzsize: 8352 => 8361 [+9 bytes / +0.11%]
other/codesize/test_codesize_cxx_wasmfs.gzsize: 3653 => 3656 [+3 bytes / +0.08%]
other/codesize/test_codesize_cxx_wasmfs.jssize: 7914 => 7913 [-1 bytes / -0.01%]
other/codesize/test_codesize_files_js_fs.gzsize: 7656 => 7659 [+3 bytes / +0.04%]
other/codesize/test_codesize_files_wasmfs.gzsize: 2882 => 2884 [+2 bytes / +0.07%]
other/codesize/test_codesize_files_wasmfs.jssize: 6202 => 6200 [-2 bytes / -0.03%]
other/codesize/test_codesize_hello_O0.gzsize: 8017 => 8014 [-3 bytes / -0.04%]
other/codesize/test_codesize_hello_O0.jssize: 21597 => 21589 [-8 bytes / -0.04%]
other/codesize/test_codesize_hello_O1.gzsize: 2697 => 2692 [-5 bytes / -0.19%]
other/codesize/test_codesize_hello_O1.jssize: 6911 => 6906 [-5 bytes / -0.07%]
other/codesize/test_codesize_hello_O2.gzsize: 2359 => 2361 [+2 bytes / +0.08%]
other/codesize/test_codesize_hello_O2.jssize: 4835 => 4833 [-2 bytes / -0.04%]
other/codesize/test_codesize_hello_O3.gzsize: 2298 => 2304 [+6 bytes / +0.26%]
other/codesize/test_codesize_hello_O3.jssize: 4757 => 4755 [-2 bytes / -0.04%]
other/codesize/test_codesize_hello_Os.gzsize: 2298 => 2304 [+6 bytes / +0.26%]
other/codesize/test_codesize_hello_Os.jssize: 4757 => 4755 [-2 bytes / -0.04%]
other/codesize/test_codesize_hello_Oz.gzsize: 2281 => 2284 [+3 bytes / +0.13%]
other/codesize/test_codesize_hello_Oz.jssize: 4724 => 4722 [-2 bytes / -0.04%]
other/codesize/test_codesize_hello_dylink.gzsize: 6023 => 6021 [-2 bytes / -0.03%]
other/codesize/test_codesize_hello_dylink.jssize: 13300 => 13296 [-4 bytes / -0.03%]
other/codesize/test_codesize_hello_export_nothing.gzsize: 1682 => 1686 [+4 bytes / +0.24%]
other/codesize/test_codesize_hello_export_nothing.jssize: 3637 => 3632 [-5 bytes / -0.14%]
other/codesize/test_codesize_hello_wasmfs.gzsize: 2298 => 2304 [+6 bytes / +0.26%]
other/codesize/test_codesize_hello_wasmfs.jssize: 4757 => 4755 [-2 bytes / -0.04%]
other/codesize/test_codesize_libcxxabi_message_O3.gzsize: 1876 => 1880 [+4 bytes / +0.21%]
other/codesize/test_codesize_libcxxabi_message_O3.jssize: 4000 => 3996 [-4 bytes / -0.10%]
other/codesize/test_codesize_libcxxabi_message_O3_standalone.gzsize: 1914 => 1915 [+1 bytes / +0.05%]
other/codesize/test_codesize_libcxxabi_message_O3_standalone.jssize: 4048 => 4044 [-4 bytes / -0.10%]
other/codesize/test_codesize_mem_O3.gzsize: 2328 => 2329 [+1 bytes / +0.04%]
other/codesize/test_codesize_mem_O3.jssize: 4892 => 4890 [-2 bytes / -0.04%]
other/codesize/test_codesize_mem_O3_grow.gzsize: 2478 => 2480 [+2 bytes / +0.08%]
other/codesize/test_codesize_mem_O3_grow.jssize: 5177 => 5175 [-2 bytes / -0.04%]
other/codesize/test_codesize_mem_O3_grow_standalone.gzsize: 2180 => 2184 [+4 bytes / +0.18%]
other/codesize/test_codesize_mem_O3_grow_standalone.jssize: 4585 => 4583 [-2 bytes / -0.04%]
other/codesize/test_codesize_mem_O3_standalone.gzsize: 2143 => 2149 [+6 bytes / +0.28%]
other/codesize/test_codesize_mem_O3_standalone.jssize: 4517 => 4513 [-4 bytes / -0.09%]
other/codesize/test_codesize_mem_O3_standalone_lib.gzsize: 1900 => 1903 [+3 bytes / +0.16%]
other/codesize/test_codesize_mem_O3_standalone_lib.jssize: 4047 => 4043 [-4 bytes / -0.10%]
other/codesize/test_codesize_mem_O3_standalone_narg.gzsize: 1914 => 1915 [+1 bytes / +0.05%]
other/codesize/test_codesize_mem_O3_standalone_narg.jssize: 4048 => 4044 [-4 bytes / -0.10%]
other/codesize/test_codesize_mem_O3_standalone_narg_flto.gzsize: 1914 => 1915 [+1 bytes / +0.05%]
other/codesize/test_codesize_mem_O3_standalone_narg_flto.jssize: 4048 => 4044 [-4 bytes / -0.10%]
other/codesize/test_codesize_minimal_64.gzsize: 1439 => 1442 [+3 bytes / +0.21%]
other/codesize/test_codesize_minimal_64.jssize: 3064 => 3058 [-6 bytes / -0.20%]
other/codesize/test_codesize_minimal_O0.gzsize: 6554 => 6549 [-5 bytes / -0.08%]
other/codesize/test_codesize_minimal_O0.jssize: 17637 => 17629 [-8 bytes / -0.05%]
other/codesize/test_codesize_minimal_O1.gzsize: 1531 => 1532 [+1 bytes / +0.07%]
other/codesize/test_codesize_minimal_O1.jssize: 3713 => 3706 [-7 bytes / -0.19%]
other/codesize/test_codesize_minimal_O2.gzsize: 1380 => 1381 [+1 bytes / +0.07%]
other/codesize/test_codesize_minimal_O2.jssize: 2812 => 2806 [-6 bytes / -0.21%]
other/codesize/test_codesize_minimal_O3.jssize: 2762 => 2756 [-6 bytes / -0.22%]
other/codesize/test_codesize_minimal_Os.jssize: 2762 => 2756 [-6 bytes / -0.22%]
other/codesize/test_codesize_minimal_Oz-ctors.jssize: 2747 => 2741 [-6 bytes / -0.22%]
other/codesize/test_codesize_minimal_Oz.jssize: 2762 => 2756 [-6 bytes / -0.22%]
other/codesize/test_codesize_minimal_esm.gzsize: 1496 => 1411 [-85 bytes / -5.68%]
other/codesize/test_codesize_minimal_esm.jssize: 3138 => 2929 [-209 bytes / -6.66%]
other/codesize/test_codesize_minimal_pthreads.gzsize: 4184 => 4157 [-27 bytes / -0.65%]
other/codesize/test_codesize_minimal_pthreads.jssize: 8711 => 8593 [-118 bytes / -1.35%]
other/codesize/test_codesize_minimal_wasmfs.jssize: 2762 => 2756 [-6 bytes / -0.22%]
other/test_INCOMING_MODULE_JS_API.js.size: 3772 => 3913 [+141 bytes / +3.74%]
other/test_unoptimized_code_size.js.size: 53866 => 53867 [+1 bytes / +0.00%]
other/test_unoptimized_code_size_no_asserts.js.size: 29065 => 29067 [+2 bytes / +0.01%]
other/test_unoptimized_code_size_strict.js.size: 52649 => 52650 [+1 bytes / +0.00%]

Average change: -0.15% (-6.66% - +3.74%)
```
@sbc100 sbc100 force-pushed the unify_scriptDirectory branch from 505f533 to 3d41373 Compare December 18, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken