New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix post function on AudioWorklet #23108

Open

mighty1231 wants to merge 1 commit into emscripten-core:main from mighty1231:audio-worklet-post-sig

mighty1231 commented Dec 9, 2024

This commit changes the old term readAsmConstArgs to the new term readEmAsmArgs, due to conflict of #16449 and #18218

Background history:

Audio Worklets #16449 proposed, introducing AudioWorklet earlier
Factor out runEmAsmFunction. NFC #18218 proposed, renaming readAsmConstArgs to readEmAsmArgs
Factor out runEmAsmFunction. NFC #18218 merged earlier
Audio Worklets #16449 merged later, using the old term readAsmConstArgs


          Fix post function on AudioWorklet

7f4c6b9

This commit changes the old term `readAsmConstArgs` to the
new term `readEmAsmArgs`, due to conflict of emscripten-core#16449 and emscripten-core#18218

Background history:

1. emscripten-core#16449 proposed, introducing AudioWorklet earlier
2. emscripten-core#18218 proposed, renaming readAsmConstArgs to readEmAsmArgs
3. emscripten-core#18218 merged earlier
4. emscripten-core#16449 merged later, using the old term `readAsmConstArgs`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet