ID-Caching #224
Merged
ID-Caching #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very simple caching mechanism for Group- and Permission-IDS
Added basic transaction-handling to delete_user(), delete_perm() and delete_group(); (And removed some trailing spaces by accident ;))
|
This now includes the transaction handling, too. |
|
Sweet 😄 I'll take a look over it later. |
|
Thanks, I'll merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically just a "proof-of-concept" for ID-caching (without using CI's caching library).
It precaches all Group/Permission-IDs in the constructor and uses that data in the get_perm/group_id() functions.
I'm "normalizing" the permission/group-names a bit before using them as array keys. I'm doing this so something like
get_perm_id('Test')and
get_perm_id('test')will return the same ID.