Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix always update configmap #1016

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

Rory-Z
Copy link
Member

@Rory-Z Rory-Z commented Feb 21, 2024

No description provided.

@Rory-Z Rory-Z force-pushed the fix/fix-always-update-configmap branch from 1cf0ad7 to f840106 Compare February 21, 2024 13:24
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (a3ec997) 76.84% compared to head (f840106) 76.82%.

Files Patch % Lines
controllers/apps/v2beta1/sync_emqx_config.go 33.33% 7 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1016      +/-   ##
==========================================
- Coverage   76.84%   76.82%   -0.03%     
==========================================
  Files          67       67              
  Lines        6153     6152       -1     
==========================================
- Hits         4728     4726       -2     
  Misses       1199     1199              
- Partials      226      227       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rory-Z Rory-Z merged commit e85cffc into emqx:main Feb 21, 2024
32 of 34 checks passed
@Rory-Z Rory-Z deleted the fix/fix-always-update-configmap branch February 21, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant