add nested complexity by knorrest · Pull Request #72 · empear-analytics/analysis-target

knorrest · 2023-01-05T10:36:31Z

Change-Id: I9eda989f7f0f13210bc66932a50455345c02eb7a

kalletest

✅ Quality Gates: OK

Declining Code Health: 1 findings(s) 🚩
Improving Code Health: 0 findings(s) ✅
Affected Hotspots: 1 files(s) 🔥

Recommended Review Level: Inconclusive -- Not enough commits to recommend a review strategy. The recommendation will be enabled automatically once you have more development activity.
View detailed results in CodeScene

🚩 Negative Code Health Impact (highest to lowest):

Deep, Nested Complexity js-example.js: mark_purchased - Low 🔥

kalletest

✅ Quality Gates: OK

Declining Code Health: 1 findings(s) 🚩
Improving Code Health: 0 findings(s) ✅
Affected Hotspots: 1 files(s) 🔥

Recommended Review Level: Inconclusive -- Not enough commits to recommend a review strategy. The recommendation will be enabled automatically once you have more development activity.
View detailed results in CodeScene

🚩 Negative Code Health Impact (highest to lowest):

Deep, Nested Complexity js-example.js: mark_purchased - Low 🔥

kalletest

❌ Quality Gates: FAILED

Declining Code Health: 1 findings(s) 🚩
Improving Code Health: 0 findings(s) ✅
Affected Hotspots: 1 files(s) 🔥

Recommended Review Level: Inconclusive -- Not enough commits to recommend a review strategy. The recommendation will be enabled automatically once you have more development activity.
View detailed results in CodeScene

🚩 Negative Code Health Impact (highest to lowest):

Deep, Nested Complexity js-example.js: mark_purchased - Low 🔥

kalletest · 2023-02-24T15:15:40Z

+function mark_purchased(transaction) {
+    transaction.state = TransactionState.PURCHASED
+    for (item in transaction.items) {
+        if (item.mtb_product_ids) {
+        if (item.mtb_product_ids) {
+            for (mp_id in item.mtb_product_ids) {
+                try {
+                    mtb_prod = get_db_mtb_product(None, mp_id, all=True, refresh=False)
+                    mtb_prod.purchased = True
+                    mtb_prod.save()
+                }
+                catch(exc) {
+                    logger.error("Failed to mark mtb_product {mp_id} as purchase", exc_info=exc)
+                }
+            }
+        }
+        }
+    }
+  }


❌ New issue: Deep, Nested Complexity Impact on Code Health Score -0.5 (-0.5 in this PR)
mark_purchased has a nested complexity depth of 4, threshold = 4

Why does this problem occur?

This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health. Read more.

_{To ignore this warning click here.}

knorrest · 2026-05-20T11:38:24Z

/cs-agent skill:fix-code-health-degradations

github-actions · 2026-05-20T11:44:28Z

CodeScene Refactoring Agent

✅ Completed

Summary

Fixed 2 Code Health degradations introduced in test/js-example.js.
Code Health improved from 9.09 → 10.0. Quality gate: passed.

Changes

Analyze change set — 2 degradations found in test/js-example.js (Deep Nested Complexity in mark_purchased, Excess Function Arguments in extractEvents)
Review flagged files — mark_purchased (nesting depth 4), extractEvents (7 arguments)
Apply fixes — grouped extractEvents args into ExtractEventsArgs type; extracted mark_mtb_product_purchased helper and removed duplicate if-guard
Verify improvements — Code Health 9.09 → 10.0, quality gates passed

Commits

ed70613 - refactor(js-example): fix Code Health degradations in extractEvents and mark_purchased

Finished at 2026-05-20 11:45:59 UTC

knorrest · 2026-05-22T07:48:01Z

/cs-agent skill:fix-code-health-degradations

github-actions · 2026-05-22T07:48:10Z

CodeScene Refactoring Agent

❌ Failed

Progress

Analyze change set — ⚠️ CodeScene access token is invalid or expired
Apply fixes

Failed at 2026-05-22 07:49:23 UTC

knorrest · 2026-05-22T07:55:43Z

/cs-agent skill:fix-code-health-degradations

github-actions · 2026-05-22T07:55:53Z

CodeScene Refactoring Agent

✅ Completed

Summary

Fixed code health degradation in test/js-example.js introduced by the mark_purchased function.

Issues fixed:

Deep, Nested Complexity: extracted inner loop body into mark_mtb_products_purchased helper function, reducing nesting from 4 levels to 2 in each function
Duplicate Condition: removed redundant duplicate if (item.mtb_product_ids) check

Changes

Analyze change set — 1 file changed: test/js-example.js with mark_purchased function
Review flagged file — deep nesting (4 levels) and duplicate condition identified
Apply fixes — extracted helper function, removed duplicate condition
Verify improvements — nesting reduced from 4 to max 2 levels per function

Commits

1d39f58 - refactor: fix deep nesting and duplicate condition in mark_purchased

Finished at 2026-05-22 07:59:18 UTC

knorrest · 2026-05-22T08:15:04Z

/cs-agent skill:fix-code-health-degradations

github-actions · 2026-05-22T08:15:14Z

CodeScene Refactoring Agent

✅ Completed

Summary

Fixed code health degradations in test/js-example.js introduced by the mark_purchased function.

Issues fixed:

Removed duplicate if (item.mtb_product_ids) condition (Bumpy Road Ahead)
Extracted try/catch block into mark_mtb_product_purchased helper to reduce nesting from 4 to 2 levels (Deep Nested Complexity)

Changes

Analyze change set — deep nested complexity and duplicate condition in mark_purchased (test/js-example.js)
Review flagged file — confirmed 2 smells: Deep Nested Complexity and Bumpy Road (duplicate if)
Apply fixes — extracted helper function, removed duplicate conditional
Verify improvements — nesting reduced from 4 to 2 levels, duplicate condition removed

Commits

5dec9e7 - refactor(mark_purchased): fix deep nesting and duplicate condition

Finished at 2026-05-22 08:21:08 UTC

codescene-delta-analysis · 2026-05-28T15:43:46Z

/cs-agent skill:fix-code-health-degradations

github-actions · 2026-05-28T15:44:00Z

CodeScene Refactoring Agent

✅ Completed

Summary

test/js-example.js improved from 9.09 to 10.0 (Optimal Code).
Fixed 2 newly introduced degradations: Excess Number of Function Arguments in extractEvents and Deep Nested Complexity in mark_purchased.

Changes

Analyze change set — 2 degradations in test/js-example.js (Deep Nested Complexity, Excess Function Arguments)
Apply fixes — introduced EventContext type object to reduce extractEvents args (7→1); extracted mark_mtb_products_purchased helper to flatten nesting in mark_purchased
Verify improvements — Code Health 9.09 → 10.0, quality gates passed

Commits

f554d1d - refactor: fix code health degradations in js-example.js

Finished at 2026-05-28 15:46:16 UTC

codescene-delta-analysis · 2026-05-29T06:44:08Z

/cs-agent skill:fix-code-health-degradations

github-actions · 2026-05-29T06:44:17Z

CodeScene Refactoring Agent

✅ Completed

Summary

Fixed 2 code health degradations in test/js-example.js.
Code Health improved from 9.09 to 10.0 (Optimal).

Changes

Analyze change set — 2 degradations found in test/js-example.js (Deep Nested Complexity, Excess Function Arguments)
Review flagged files — extractEvents had 7 args; mark_purchased had nesting depth 4
Apply fixes — introduced ExtractEventsOptions type; extracted mark_mtb_products_purchased helper
Verify improvements — Code Health 9.09 → 10.0, all quality gates passed

Commits

b00ca82 - refactor: fix code health degradations in js-example.js

Finished at 2026-05-29 06:46:07 UTC

codescene-delta-analysis · 2026-05-29T07:48:32Z

/cs-agent skill:fix-code-health-degradations

github-actions · 2026-05-29T07:48:42Z

CodeScene Refactoring Agent

✅ Completed

Summary

Fixed 2 Code Health degradations in test/js-example.js.
Score improved from 9.09 → 10.0 (Optimal Code).

Changes

Analyze change set — 2 degradations found in test/js-example.js (Deep Nested Complexity in mark_purchased, Excess Function Arguments in extractEvents)
Apply fixes — grouped extractEvents params into ExtractEventsParams type object; extracted mark_mtb_products_purchased helper to reduce nesting depth
Verify improvements — quality gates passed, Code Health 9.09 → 10.0

Commits

48eca5a - refactor(js-example): fix code health degradations in extractEvents and mark_purchased

Finished at 2026-05-29 07:50:39 UTC

Change-Id: I9eda989f7f0f13210bc66932a50455345c02eb7a

codescene-delta-analysis · 2026-05-29T09:16:16Z

/cs-agent skill:fix-code-health-degradations

github-actions · 2026-05-29T09:16:26Z

CodeScene Refactoring Agent

✅ Completed

Summary

Fixed 2 newly introduced Code Health degradations in test/js-example.js.
Code Health improved from 9.09 → 10.0 (Optimal).

Changes

Analyze change set — 2 degradations found in test/js-example.js (Deep Nested Complexity, Excess Function Arguments)
Review flagged files — mark_purchased (nesting depth 4) and extractEvents (7 args)
Apply fixes — extracted params type for extractEvents; extracted mark_mtb_products_purchased helper and removed duplicate if-guard
Verify improvements — Code Health 9.09 → 10.0, all quality gates passed

Commits

4280c30 - refactor: fix code health degradations in js-example.js

Finished at 2026-05-29 09:18:28 UTC · Detailed steps? View logs

codescene-access

Gates Failed
Enforce critical code health rules (1 file with Deep, Nested Complexity)

Fix Code Health degradations ℹ️

Gates Passed
4 Quality Gates Passed

Reason for failure

Enforce critical code health rules	Violations	Code Health Impact
js-example.js	1 critical rule	9.69 → 9.10	Suppress

See analysis details in CodeScene

Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

codescene-access · 2026-06-04T09:16:03Z

+function mark_purchased(transaction) {
+    transaction.state = TransactionState.PURCHASED
+    for (item in transaction.items) {
+        if (item.mtb_product_ids) {
+        if (item.mtb_product_ids) {
+            for (mp_id in item.mtb_product_ids) {
+                try {
+                    mtb_prod = get_db_mtb_product(None, mp_id, all=True, refresh=False)
+                    mtb_prod.purchased = True
+                    mtb_prod.save()
+                }
+                catch(exc) {
+                    logger.error("Failed to mark mtb_product {mp_id} as purchase", exc_info=exc)
+                }
+            }
+        }
+        }
+    }
+  }


❌ New issue: Deep, Nested Complexity
mark_purchased has a nested complexity depth of 4, threshold = 4

_Suppress

knorrest force-pushed the minor-degradation branch 3 times, most recently from 17d0513 to 149c692 Compare January 5, 2023 10:46

kalletest Bot reviewed Jan 5, 2023

View reviewed changes

knorrest force-pushed the minor-degradation branch from 149c692 to 3fba4c6 Compare January 5, 2023 11:00

kalletest Bot reviewed Jan 5, 2023

View reviewed changes

knorrest force-pushed the minor-degradation branch from 3fba4c6 to 6e5c9bf Compare January 5, 2023 11:02

knorrest closed this Feb 24, 2023

knorrest reopened this Feb 24, 2023

knorrest closed this Feb 24, 2023

knorrest reopened this Feb 24, 2023

knorrest closed this Feb 24, 2023

knorrest reopened this Feb 24, 2023

kalletest Bot reviewed Feb 24, 2023

View reviewed changes

This comment was marked as outdated.

Sign in to view

knorrest force-pushed the minor-degradation branch from ed70613 to 6e5c9bf Compare May 22, 2026 07:47

This comment was marked as outdated.

Sign in to view

knorrest force-pushed the minor-degradation branch from 1d39f58 to 6e5c9bf Compare May 22, 2026 08:14

This comment was marked as outdated.

Sign in to view

knorrest force-pushed the minor-degradation branch from f554d1d to 764438c Compare May 28, 2026 16:42

This comment was marked as outdated.

Sign in to view

knorrest force-pushed the minor-degradation branch from b00ca82 to 764438c Compare May 29, 2026 07:46

This comment was marked as outdated.

Sign in to view

add nested complexity

7d5b3bc

Change-Id: I9eda989f7f0f13210bc66932a50455345c02eb7a

knorrest force-pushed the minor-degradation branch from 48eca5a to 7d5b3bc Compare May 29, 2026 09:14

This comment was marked as outdated.

Sign in to view

codescene-delta-analysis Bot approved these changes May 29, 2026

View reviewed changes

knorrest force-pushed the minor-degradation branch from 4280c30 to 7d5b3bc Compare June 4, 2026 09:15

codescene-access Bot reviewed Jun 4, 2026

View reviewed changes

codescene-staging Bot approved these changes Jun 4, 2026

View reviewed changes

Uh oh!

Conversation

knorrest commented Jan 5, 2023

Uh oh!

kalletest Bot left a comment

Choose a reason for hiding this comment

🚩 Negative Code Health Impact (highest to lowest):

Uh oh!

kalletest Bot left a comment

Choose a reason for hiding this comment

🚩 Negative Code Health Impact (highest to lowest):

Uh oh!

kalletest Bot left a comment

Choose a reason for hiding this comment

🚩 Negative Code Health Impact (highest to lowest):

Uh oh!

kalletest Bot Feb 24, 2023

Choose a reason for hiding this comment

Why does this problem occur?

Uh oh!

knorrest commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodeScene Refactoring Agent

Summary

Changes

Commits

Uh oh!

This comment was marked as outdated.

Uh oh!

knorrest commented May 22, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodeScene Refactoring Agent

Progress

Uh oh!

This comment was marked as outdated.

Uh oh!

knorrest commented May 22, 2026

Uh oh!

github-actions Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodeScene Refactoring Agent

Summary

Changes

Commits

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

knorrest commented May 22, 2026

Uh oh!

github-actions Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodeScene Refactoring Agent

Summary

Changes

Commits

Uh oh!

This comment was marked as outdated.

Uh oh!

codescene-delta-analysis Bot commented May 28, 2026

Uh oh!

github-actions Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodeScene Refactoring Agent

Summary

Changes

Commits

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

github-actions Bot commented May 20, 2026 •

edited

Loading

github-actions Bot commented May 22, 2026 •

edited

Loading

github-actions Bot commented May 22, 2026 •

edited

Loading

github-actions Bot commented May 22, 2026 •

edited

Loading

github-actions Bot commented May 28, 2026 •

edited

Loading

github-actions Bot commented May 29, 2026 •

edited

Loading

github-actions Bot commented May 29, 2026 •

edited

Loading

github-actions Bot commented May 29, 2026 •

edited by knorrest

Loading