CI: remove cruft from Lerna migration (#48)

emmercm · Sep 21, 2024 · ea4e4a0 · ea4e4a0
1 parent dbbce40
commit ea4e4a0
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 10 deletions.
diff --git a/.github/workflows/node-test.yml b/.github/workflows/node-test.yml
@@ -51,7 +51,6 @@ jobs:
     if: ${{ needs.path-filter.outputs.changes == 'true' }}
     runs-on: ${{ matrix.os }}
     strategy:
-      fail-fast: false
       matrix:
         os: [ ubuntu-latest, macos-13, macos-14, windows-latest ]
         node-version:

diff --git a/packages/chdman-darwin-arm64/package.json b/packages/chdman-darwin-arm64/package.json
@@ -20,7 +20,7 @@
   },
   "scripts": {
     "build": "tsc --build --verbose",
-    "prepack": "npm run build && pwd && cp -f ../../LICENSE ../../README.md ./",
+    "prepack": "npm run build && cp -f ../../LICENSE ../../README.md ./",
     "postpack": "rm ./LICENSE ./README.md"
   },
   "description": "💿 chdman binaries and wrapper for Node.js.",

diff --git a/packages/chdman/src/chdman/chdmanBin.ts b/packages/chdman/src/chdman/chdmanBin.ts
@@ -41,9 +41,7 @@ export default class ChdmanBin {
         ChdmanBin.CHDMAN_BIN = prebuilt;
         return prebuilt;
       }
-    } catch (error) {
-      console.log(error);
-    }
+    } catch { /* ignored */ }
 
     const resolved = await which('chdman', { nothrow: true });
     if (resolved) {

diff --git a/packages/chdman/test/chdman/chdmanCd.test.ts b/packages/chdman/test/chdman/chdmanCd.test.ts
@@ -7,11 +7,6 @@ import ChdmanInfo from '../../src/chdman/chdmanInfo.js';
 import TestUtil from '../testUtil.js';
 import { CHDType } from '../../src/chdman/common.js';
 
-// import {jest} from '@jest/globals';
-// jest.unstable_mockModule(`chdman-${process.platform}-${process.arch}`, () => {
-//   const i = 0;
-// });
-
 it('should fail on nonexistent file', async () => {
   const temporaryChd = `${await TestUtil.mktemp(path.join(os.tmpdir(), 'dummy'))}.chd`;
   const temporaryCue = `${temporaryChd}.cue`;