Pass client certificate and SNI to auth service #5823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
|
🤏 close to being green |
This enables the auth service to do things like mTLS. Signed-off-by: Ian Kerins <[email protected]>
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
kflynn
force-pushed
the
flynn/isker-5821
branch
from
c03a6d4 to
2ae7171
Compare
dosubot
bot
added
size:L
the-wondersmith
approved these changes
Feb 14, 2025
This was referenced Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI PR for @isker's PR #5281, thanks!!
Reviewers: review commit by commit. The last commit is all mechanical where one of our formatters got upgraded and decided that it really likes double quotes instead of single quotes. 🙄