issue-5702 - Multiple duplicate mappings generated for single mapping resource fixed #5722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resource fixed Signed-off-by: Sekar Saravanan <[email protected]>
sekar-saravanan
force-pushed
the
flynn/v4-5715
branch
from
c142850
to
f270233
Compare
|
Taking this for v4, thank you @sekar-saravanan!! 🙂 |
|
(For the curious, I pulled it onto a local branch and ran Go & Python unit tests, looks good!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Emissary creating multiple duplicate mappings for single mapping resource in ir.json and econf.json while adding weight for canary release
Related Issues
#5702
Testing
manual tests
Checklist
Does my change need to be backported to a previous release?
I made sure to update
CHANGELOG.md.This is unlikely to impact how Ambassador performs at scale.
My change is adequately tested.
I updated
DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.The changes in this PR have been reviewed for security concerns and adherence to security best practices.