Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support parent container #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support parent container #356

wants to merge 1 commit into from

Conversation

joaom00
Copy link
Contributor

@joaom00 joaom00 commented May 21, 2024

This PR adds support for a parent container via container prop on Root

Fixes #296

@vercel Vercel
Copy link

vercel bot commented May 21, 2024

@joaom00 is attempting to deploy a commit to the emil Team on Vercel.

A member of the Team first needs to authorize it.

danim47c
danim47c approved these changes Jul 11, 2024
View reviewed changes
Copy link

@danim47c danim47c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem to be perfect, working properly

@RahulBirCodes
Copy link

Seems to be working great, any updates on getting this merged? Currently facing a bottleneck without this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjoeoui itsjoeoui itsjoeoui approved these changes

@danim47c danim47c danim47c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to set parent container
4 participants
@joaom00 @RahulBirCodes @itsjoeoui @danim47c