Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide sticky elements #209

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

emilkowalski
Copy link
Owner

No description provided.

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vaul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2024 10:38am

@emilkowalski emilkowalski merged commit e106e03 into main Jan 15, 2024
2 of 3 checks passed
@Dearest
Copy link

Dearest commented Jan 18, 2024

when can I use this pr code in new vaul version (maybe 0.8.1)?

@emilkowalski
Copy link
Owner Author

Very soon!

@emilkowalski
Copy link
Owner Author

@Dearest This is live now!

@jsefiani
Copy link

Hey @emilkowalski, I just tested out the latest version, and I noticed that scrolling up inside a drawer doesn't work anymore, most likely because of this change.

@emilkowalski
Copy link
Owner Author

emilkowalski commented Jan 20, 2024

Where doesn't it work? It works fine for me in the codesandbox demo.

RPReplay_Final1705763620.mov

@Lcarv20
Copy link

Lcarv20 commented Jan 26, 2024

Hi there, sorry for bringing this back up, but I am using the latest version and the sticky components still disappear. Maybe I am doing something wrong, would you care to take a look at this sandbox?

also a vid:

output.mp4

(this maybe should be a new issue) One suggestion I also would like to make is to keep track the body background state before and after toggling, to not keep it black after closing, my current solution is something like:

...
       onClose={() => {
         document.body.style.background = "";
       }}
...

I am saying this because I noticed on iPhones with notch the background on the top corners stays black after interacting with the drawer component

#191 #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants