Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close animation removed when using snapPoints and onOpenChange #361

Open
bodinsamuel opened this issue May 28, 2024 · 3 comments
Open

Close animation removed when using snapPoints and onOpenChange #361

bodinsamuel opened this issue May 28, 2024 · 3 comments

Comments

@bodinsamuel
Copy link

When using snapPoints and onOpenChange (I think) the close animation does not fire appropriately (cf sandbox and video)

https://codesandbox.io/p/devbox/drawer-with-scale-forked-64hkwq?workspaceId=f3e40dd0-e986-422e-a592-b767ba01fa03

Screen.Recording.2024-05-28.at.18.27.34.mov
@franciscohanna92
Copy link

@bodinsamuel Weirdly enough, if you remove the open and onOpenChange properties and just leave the drawer manage the open state internally, the problem goes away. Check this Codesandbox.

@adnan-smlatic
Copy link

@franciscohanna92 Did you end up solving this? Having the same issue and I need to have open and onOpenChange. There's a pull request that fixes this in #354, but @emilkowalski is unresponsive

@TasseDeCafe
Copy link

I'm having the same issue, removing snapPoints fixes the animation, but it would be nice to be able to use snapPoints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants