feat(logs): share an operation via URL #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
commented
May 29, 2024
| return ( | ||
| <Drawer direction="right" snapPoints={[drawerWidth]} handleOnly={true} noBodyStyles={true}> | ||
| <Drawer direction="right" snapPoints={[drawerWidth]} handleOnly={true} noBodyStyles={true} onOpenChange={(v) => setTimeout(() => onOpenChange(v), 500)}> |
There was a problem hiding this comment.
The drawer has an issue emilkowalski/vaul#361
bodinsamuel
changed the title
TBonnin
approved these changes
May 31, 2024
It's the Skeleton. Locally it loads too fast to be relevant but in prod it can be nice, I'll double check with gab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes NAN-1013
Fixes NAN-1003
Contributes to NAN-908
Allow to share an operation details via URL
We just append a query param and when it's there we open the Drawer back (datadog style)
Update copybutton with appropriate new icon
How to test?