Skip to content

Commit

Permalink
fix: horizontal shift (#443)
Browse files Browse the repository at this point in the history
  • Loading branch information
emilkowalski authored Sep 24, 2024
1 parent 3b806ea commit 09d6ede
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions src/use-prevent-scroll.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,29 +104,18 @@ export function usePreventScroll(options: PreventScrollOptions = {}) {
if (preventScrollCount === 1) {
if (isIOS()) {
restore = preventScrollMobileSafari();
} else {
restore = preventScrollStandard();
}
}

return () => {
preventScrollCount--;
if (preventScrollCount === 0) {
restore();
restore?.();
}
};
}, [isDisabled]);
}

// For most browsers, all we need to do is set `overflow: hidden` on the root element, and
// add some padding to prevent the page from shifting when the scrollbar is hidden.
function preventScrollStandard() {
return chain(
setStyle(document.documentElement, 'paddingRight', `${window.innerWidth - document.documentElement.clientWidth}px`),
// setStyle(document.documentElement, 'overflow', 'hidden'),
);
}

// Mobile Safari is a whole different beast. Even with overflow: hidden,
// it still scrolls the page in many situations:
//
Expand Down

0 comments on commit 09d6ede

Please sign in to comment.