Eframe: Use alternate display size if browser is firefox #7873
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7873-firefox-scaling View snapshot changes at kitdiff |
Contributor
Author
|
This is open as a draft due to me having issues with running the check script. I will be able to dedicate more time to trying to run the check script later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in firefox the display scaling is read as 2x what it should be. This causes issues as cursor position is still using the 1x scaling, and any egui applications being at 2x the desired scale.
This is a patchwork fix that detects is the browser is firefox by looking at the user agent (any of web devs that have a better knowledge of how to detect a firefox browser please let me know) and falls back to an alternate display size calculation that produces the expected 1x scaling.