Localization of Widgets strings #426
Conversation
| /// Specifies the languages currently available for localization and is required by [`crate::Context::set_localization`] as the parameter type. | ||
| pub enum Language { | ||
| English, | ||
| BahasaMalaysia, |
There was a problem hiding this comment.
Do we need this list? Can't the user just call context.set_localization(Localization::malay()); instead? That way it is also easy for a user to add a new language without having to make a PR to egui.
There was a problem hiding this comment.
Localization::lang could be changed to &'static str too (e.g. "english")
There was a problem hiding this comment.
Localization::langcould be changed to&'static strtoo (e.g. "english")
Agree, some clarification: <language code>[_<territory code>] should be used (en, en_US and so on)
| @@ -53,6 +56,9 @@ pub struct Memory { | |||
| /// new fonts that will be applied at the start of the next frame | |||
| pub(crate) new_font_definitions: Option<epaint::text::FontDefinitions>, | |||
|
|
|||
| /// new language that will be applied at the start of the next frame | |||
| pub(crate) new_language: Option<Language>, | |||
There was a problem hiding this comment.
No need for this - let's make it instant instead.
| /// Sets the current language of the default texts within [`crate::widgets`] and [`crate::containers`]. | ||
| /// | ||
| /// The languages available for localization can be seen in [`crate::localization::Language`]. | ||
| pub fn set_localization(&self, lang: Language) { |
There was a problem hiding this comment.
| pub fn set_localization(&self, lang: Language) { | |
| pub fn set_localization(&self, localization: Localization) { |
|
I think perhaps we should instead remove strings from egui (like we did in #704) instead of going down this path, or let the user set the egui helper string directly, i.e. something like this, where the user of egui choses what goes where:
|
Closes #136.
I'm in the middle of something right now so my write-up will be limited.
Not sure if I'm doing anything right to be honest but here's the gist of it:
Localizationstruct andLanguageenumLocalizationhas methods pertaining to the language to localize into. For example,malay()returns a copy ofLocalizationwith all fields filled with Bahasa Malaysia texts; English is a bit special as it is covered by thedefault()Contextnow has alocalizationfield that storesLocalizationContextcan be used to set localization by using it in tandem with theLanguageenumnew_languageas a field inMemory; it works similarly (I think) tonew_font_definitionsandnew_pixels_per_pointwherein if available, it'll set the new language at the start of the next frameLocalizationstruct supports two localized texts - English and Bahasa Malaysia. However, the extent of localization is only for the color picker widget; I'll add more if the current code is satisfactoryMy concerns:
clone(); not sure if that's a good idea