Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab identation for multiline text edit #246
Tab identation for multiline text edit #246
Changes from 8 commits
86c4b76
2f806a8
94c1801
ba12f9e
13ed86d
19e2608
b3aa498
5557b17
cb66aaa
1d271d5
b15a5c7
724901e
f2ddd8f
4633084
5e6fc2d
aafcc03
d7f3805
939733b
4186356
b386599
5bc7857
7065e4e
798748d
c81132f
da2392c
9e6db0f
30fcc1e
0220a04
18429f0
1272ad9
d468dc7
061b56b
e14c549
04b8cfb
78ac783
1b3b5a4
4396c87
ae4ea45
f384003
0fe4cce
c57a147
de7a474
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is bad form to have multiple boolean arguments, as it leads to code that is very hard to decipher:
I think it is better in this case to just have the opinionated
code_editor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I crated a
CodingConfig
struct for this purpose.https://github.com/DrOptix/egui/blob/e14c5491b61574647ed837130e0a61f4c1ce98b4/egui/src/widgets/text_edit.rs#L107-L112
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here about multiple boolean arguments. If you want to set multiple values with a single call, it is better to make a config struct and pass that in (
struct CodeConfig { tabs_as_spaces: bool, tab_width: usize, … }
). This has the benefit of being more explicit and more extensible.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I crated a
CodingConfig
struct for this purpose.https://github.com/DrOptix/egui/blob/e14c5491b61574647ed837130e0a61f4c1ce98b4/egui/src/widgets/text_edit.rs#L107-L112