Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Json chooser v2: A complex chooser to handle options #228

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

columbarius
Copy link
Collaborator

@columbarius columbarius commented Aug 5, 2022

If we want to query the user for options like persist_mode we need to send more data than just the name of the output. We also need sth. more complex when window selection is possible.

In any case this is a PoC sending the data encoded via json between chooser and xdpw in both directions. The scheme is versioned with version (breaking) and revision (backwards compatible on the xdpw side).

Note: man-page has still the scheme from #105 . The new scheme is demonstrated in chooser-protocol.json.

Windows got an additional arbitrary id, since two toplevels can have the same app_id and title.

Supersedes: #105

CC: @emersion

@columbarius
Copy link
Collaborator Author

Updated this with an idea to separate the chooser by using choser, chooser_opts and a target struct.
There are still open todos like collecting the persist_mode.

@YellowOnion
Copy link

being able to choose the fps would be nice as well, max_fps could be a default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants