fix(makoct): Ensure same notif id is used across external call in makoctl menu
#530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider the following: The first notification has action `act1`. The user starts `makoctl menu` with no id specified to get actions from this notifications. While dmenu is open, a new notification appears. When the user confirms `act1` in dmenu, this action previously got applied to this new notification, which potentially has completely different actions/semantics. Now the behaviour is that the action gets sent to the notification from which it was obtained (this is consistent with behaviour when `-n` is passed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following:
The first notification has action
act1. The user startsmakoctl menuwith no id specified to get actions from this notifications. While dmenu is open, a new notification appears. When the user confirmsact1in dmenu, this action previously got applied to this new notification, which potentially has completely different actions/semantics.Now the behaviour is that the action gets sent to the notification from which it was obtained (this is consistent with behaviour when
-nis passed)Notes
The new behaviour could already be replicated on the user's side, but there doesn't seem to be a point in keeping the previous behaviour. The previous behaviour can be achieved by passing
-n 0