Implement (hacky) support for scalable icons #494
Conversation
Previously, any icons that were found in folders like scalable or symbolic were ignored because they didn't contain any sizing information. Instead, assume any icons ending with ".svg" to be scalable as it's the only supported vectorized format. With this, the adwaita icon theme should work again, they removed most of their fixed size icons semirecently: https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/221
| @@ -170,6 +170,13 @@ static char *resolve_icon(struct mako_notification *notif) { | |||
| for (size_t i = 0; i < found_count; ++i) { | |||
| char *relative_path = icon_glob.gl_pathv[i]; | |||
|
|
|||
| if (!strcmp(relative_path+strlen(relative_path)-4, ".svg")) { | |||
There was a problem hiding this comment.
Maybe a better approach would be to check if the size subdir is named "scalable"?
There was a problem hiding this comment.
Would have to check for "scalable" and "symbolic", but yeah, possibly. There definitely seem to be themes that have more complex SVGs for bigger sizes, so not throwing away sizing information for them may be desirable.
On the other hand I don't know if other icon themes use different names for this; though spot checking the arch repos that does seem to be a common theme.
For my usecase this definitely works, if you want I can update this PR to this commit:
Tharre@d685b90
There was a problem hiding this comment.
Hm, right, I suppose that to do things the Right Way, we'd need to parse the theme .ini files... Although, maybe we should keep parsing the size if there are .svg files in a directory with a fixed size...
Previously, any icons that were found in folders like scalable or symbolic were ignored because they didn't contain any sizing information. Instead, assume any icons ending with ".svg" to be scalable as it's the only supported vectorized format.
With this, the adwaita icon theme should work again, they removed most of their fixed size icons semirecently:
https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/221