Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Fix leaks of mako_notification in handle_notify() #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RFC: Fix leaks of mako_notification in handle_notify() #379

wants to merge 1 commit into from

Conversation

psqli
Copy link
Contributor

@psqli psqli commented Aug 24, 2021

Unify clean up on error with goto statements.

Is freeing the expected behavior?

@psqli
Fix leaks of mako_notification in handle_notify()
8dfa0df 
Unify clean up on error with goto statements.
@psqli
Copy link
Contributor Author

psqli commented Aug 24, 2021

Also, the commit 4dc382e ("Allow create_notification outside handle_notify") introduced strdup() calls inside reset_notification(), which is called by destroy_notification() just before notif is freed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@psqli